Fix buffer option in taurus trend cli

taurus-org / taurus

Moved to https://gitlab.com/taurus-org/taurus

http://taurus-scada.org

43 stars 46 forks source link

Fix buffer option in taurus trend cli #1154

Closed cpascual closed 3 years ago

cpascual commented 3 years ago

An indentation mistake provokes a premature exit when using the --buffer option in the taurus trend CLI (even on success) Fix it so that it only exits in case of error.

Also move the call to setting the buffers in the CLI command after the models have been set, in order to affect them

cpascual commented 3 years ago

@taurus-org/integrators : This is ready for review. In order to test it with taurus_pyqtgraph trends, https://github.com/taurus-org/taurus_pyqtgraph/pull/47 is required

cpascual commented 3 years ago

taurus-org/taurus_pyqtgraph#47 is already merged. can any @taurus-org/integrators have a look at this?

cpascual commented 3 years ago

Thnks @teresanunez for the review. You marked this as approved. Does this mean that it can be merged? if so, I can do it, but you can do it directly too.