search

tavicu / homebridge-samsung-tizen

Homebridge plugin for Samsung TV's with Tizen OS
MIT License
647 stars 88 forks source link

FrameTV switches present not neat #347

Closed mmarras closed 3 years ago

mmarras commented 3 years ago

Not trying to be overly critical, and also not sure if we can do anything about it on the plugin-level, but the Frames switches are presented kind of not neat because the on-off switch is just a button and is two column with the art-mode switch. The rest that follows is one column again. Can we have everything in one column? Of course we can just remove some switches from the display altogether, just curious if that could be improved. Mac.Home.app

Screenshot 2021-04-17 at 11 14 18

iPhone.home.app IMG_9234B07ED348-1

Mockup of arguably more desired layout Mockup

tavicu commented 3 years ago

Nothing we can do here. Apple decides how to display the switches, not us!

For disabling them: https://git.io/JOII1

Also Apple gives option to display them as separate tiles

mmarras commented 3 years ago

Nothing we can do here.

Well nothing we can do here is again a bit of a rushed conclusion, imho. Maybe if we think a moment we can still come up with an improvement? If we cannot change the alignment, there might be other ways to improve. For example wouldn’t it look nicer, i.e., more symmetric, if the TV switch (round) would be below the two slider switches? Another question comes to mind: why are the additional ones sliders in the first place and round as the on-off buttons too? I have seen groups with only sliders, so clearly all three could be sliders, that would already be an improvement in my opinion.

tavicu commented 3 years ago

Because that's how TVs are shown, with a rounded button. It's not rushed, i know how this work since this plugin was made almost 4 years ago ... so i had a long time learning how homekit works and what options do we have.

If you want more informations you could write to Apple :) I would like the option to customise as much as you want

As i already told you (and not rushed, but from days spent trying to find an option), on our side there is nothing we can do. TVs has rounded button as power and additional switches are shown like that. As a device you cannot decide how to display your stuff. You only get the option to set them.

Then Apple show them in this order: Main Switch , Additional Switches, Inputs

so clearly all three could be sliders, that would already be an improvement in my opinion.

Feel free to fork the plugin and frankenstein it as you like :) The only option to change from round button is to change the type of accessory (lamp for example).

mmarras commented 3 years ago

Thanks for the satisfactory additional explanation.

tavicu commented 3 years ago

And i'm sorry for my tone but i don't like things like "rushed conclusion", "so clearly all three could be sliders", and others. If you think you can do better, feel free to do it or give informations on how to do it (technically) after you made your researches :)

But i spent months on this plugin to get it to this stage and i really know how things work! I don't appreciate when someone comes to crash my party :)

Trust me when i tell you i also don't like how Apple display them. Personally i keep them as separate tiles! But after days of trying to find a solution ... there is none. At least until Apple decide to give us more options, maybe in iOS 20 ...