tavicu / homebridge-samsung-tizen

Homebridge plugin for Samsung TV's with Tizen OS
MIT License
647 stars 87 forks source link

Volume down/up from control centre shuts down TV #410

Closed JB4Lyfe closed 2 years ago

JB4Lyfe commented 2 years ago

Hello! Ive got a Samsung q80t 2020 model and recently just installed this plugin on Homebridge running from a raspberry pi. All other features and functions are working as expected, occasionally I can't turn on the tv after it being off for long periods of times.

Another issue that ive been getting quite frequently is that the TV shuts down when I use the volume keys from the iOS remote app. It happens quite frequently. Anyone had the same issues and any potential fixes? Attached is an image of my config.

Thank you so much in advance.

Screen Shot 2021-10-02 at 10 51 34 pm
tavicu commented 2 years ago

Hi,

Your problem is interesting. First time i hear about it. The volume controls only send a command (VOL_UP or VOL_DOWN) to TV. So i really don't know from where the problem could be or how to try and catch it.

We could try by opening the homebridge in debug mode homebridge -D and see the logs that are triggered when you press volume up/down

JB4Lyfe commented 2 years ago

Hi,

Your problem is interesting. First time i hear about it. The volume controls only send a command (VOL_UP or VOL_DOWN) to TV. So i really don't know from where the problem could be or how to try and catch it.

We could try by opening the homebridge in debug mode homebridge -D and see the logs that are triggered when you press volume up/down

It happens every couple days or so. I will let you know if it happens again and send through a screenshot of the debug. Thanks!

JB4Lyfe commented 2 years ago

It happened today and I managed to catch it in debug mode. For some reason it sends 2 commands, one for volume up and another for power down.

Screen Shot 2021-10-08 at 4 36 02 pm 1
tavicu commented 2 years ago

Ok. After one hour i finally found a possible scenario.

The plugin doesn't request to change the power when you interact with any key from control center. HomeKit does if it sees that the TV is off.

So somehow HomeKit sees your TV as off when you try to control the volume and sends the volume command then it tries to turn it on. Since it's the same key as powering off and your tv is already on it just powers it off.

The problem is that somehow homekit sees it off. So is a problem of slow responding network or something to requests.

If you want to dig deeper you could what i suggested here to other member: https://github.com/tavicu/homebridge-samsung-tizen/issues/417#issuecomment-935961245 That way we could see what is returning false as power status.

But i bet it's the same problem as him :)

JB4Lyfe commented 2 years ago

Ok. After one hour i finally found a possible scenario.

The plugin doesn't request to change the power when you interact with any key from control center. HomeKit does if it sees that the TV is off.

So somehow HomeKit sees your TV as off when you try to control the volume and sends the volume command then it tries to turn it on. Since it's the same key as powering off and your tv is already on it just powers it off.

The problem is that somehow homekit sees it off. So is a problem of slow responding network or something to requests.

If you want to dig deeper you could what i suggested here to other member: #417 (comment) That way we could see what is returning false as power status.

But i bet it's the same problem as him :)

Cant seem to locate the /lib/methods/base.js file.

tavicu commented 2 years ago

You must find where you installed the package. Are you running your homebridge on a docker instance?

JB4Lyfe commented 2 years ago

You must find where you installed the package. Are you running your homebridge on a docker instance?

Thanks for your reply. I’m running it off a raspberry pi 4

tavicu commented 2 years ago

I’m running it off a raspberry pi 4

You, that i got it from the first message :D i was interested to see how you are running it so i can guide you where to find the files.

You could run npm list -g --depth=0. It will get you a list with the packages installed and the first line will be the path to the folder.

Usually it should be in /usr/local/lib/node_modules/homebridge-samsung-tizen

JB4Lyfe commented 2 years ago

I’m running it off a raspberry pi 4

You, that i got it from the first message :D i was interested to see how you are running it so i can guide you where to find the files.

You could run npm list -g --depth=0. It will get you a list with the packages installed and the first line will be the path to the folder.

Usually it should be in /usr/local/lib/node_modules/homebridge-samsung-tizen

Managed to find the file via ssh Cyberduck and homebridge.local terminal. But my access was denied when I tried to edit the file.