taviso / 123elf

A native port of Lotus 1-2-3 to Linux.
1.17k stars 59 forks source link

Larger terminal window results in segmentation fault #22

Closed jeff-hines closed 2 years ago

jeff-hines commented 2 years ago

Using commit 199b81f.

I ran git pull, then make clean and then make, then copied the l123set file to my home directory before trying to run the program again.

Terminal size 80x24: Works fine Terminal size 300x70 (zsh says it's an exit code 139):

                   -`                    jeff@archpad 
                  .o+`                   ------------ 
                 `ooo/                   OS: Arch Linux x86_64 
                `+oooo:                  Host: 20BWS0PJ00 ThinkPad T450s 
               `+oooooo:                 Kernel: 5.17.9-arch1-1 
               -+oooooo+:                Uptime: 16 mins 
             `/:-:++oooo+:               Packages: 626 (pacman) 
            `/++++/+++++++:              Shell: zsh 5.9 
           `/++++++++++++++:             Resolution: 1920x1080 
          `/+++ooooooooooooo/`           WM: JWM 
         ./ooosssso++osssssso+`          Theme: Raleigh [GTK2/3] 
        .oossssso-````/ossssss+`         Icons: Papirus [GTK2/3] 
       -osssssso.      :ssssssso.        Terminal: xterm 
      :osssssss/        osssso+++.       CPU: Intel i7-5600U (4) @ 3.200GHz 
     /ossssssss/        +ssssooo/-       GPU: Intel HD Graphics 5500 
   `/ossssso+/:-        -:/+osssso+-     Memory: 1173MiB / 11843MiB 
  `+sso+:-`                 `.-/+oso:
 `++:.                           `-/+/                           
 .`                                 `/                           

jeff@archpad ~/builds/123elf (git)-[main] % ./123
[1]    5338 segmentation fault (core dumped)  ./123
                                                   %                          
139 jeff@archpad ~/builds/123elf (git)-[main] %                            :( 

Output from neofetch is included in case it helps in some way.

taviso commented 2 years ago

Thanks, I can reproduce -- I had to zoom out a lot to make it crash, you must have good eyesight :)

I'll track down the bug, maybe I should cap it in main until I can figure it out just so it doesn't crash when people are testing it... hmm.

rhaamo commented 2 years ago

Same here, term size of 308 cols and 79 lines results in:

fish: Job 1, './123' terminated by signal SIGSEGV (Address boundary error)

More larger (368 * 95) results in 123: Memory full

taviso commented 2 years ago

Okay, I have a patch for the crash, but not the Memory full issue yet - I can fix it, but it will take some debugging!

jeff-hines commented 2 years ago

@taviso Updated to 0f3a264 and can confirm the program doesn't crash with > 256 columns.

Re: eyesight -- I'm using xterm with default settings, can barely read the terminal without squinting!