search

taviso / 123elf

A native port of Lotus 1-2-3 to Linux.
1.17k stars 59 forks source link

Turn off banner/splash screen by default #28

Closed jserv closed 2 years ago

jserv commented 2 years ago

The banner on startup did sleep(5) which can be annoying. Environment variable "LOTUS_NO_BANNER" is introduced an an alternative way to switch. It is now disabled by default.

taviso commented 2 years ago

Thanks, this looks good to me!

I wonder if it should be an option rather than an environment variable though, what do you think? I just saw your other commit, so now we can add our own command line options. We could add a --no-banner or something?

I could go either way, let me know if you think the envvar is better!

jserv commented 2 years ago

I wonder if it should be an option rather than an environment variable though, what do you think? I just saw your other commit, so now we can add our own command line options. We could add a --no-banner or something? I could go either way, let me know if you think the envvar is better!

We can certainly add new options such as "--no-banner" or "--show-banner", but the command 123 -h would not show the options because 123 is not aware of such changes.

jserv commented 2 years ago

As stated in #33, I am looking into the feasibility of rewriting command line parser, which allows flexible usage for new options. How about merging this patch and then rewriting/extending command line parser?

taviso commented 2 years ago

Okay, that sounds good to me - I think it's a good idea, we can even filter out our own options before passing the rest to Lotus.

I just made some huge changes to get graphing working, I'll work on this some more tomorrow.

jserv commented 2 years ago

Close in favor of commit 0109296a192e5a60625c9b7b799c36279cdb7d22