search

taviso / wpunix

WordPerfect for UNIX Character Terminals
603 stars 17 forks source link

Konsole mouse support #46

Open dialognewmedia-mws opened 9 months ago

dialognewmedia-mws commented 9 months ago

I see in the wiki that Konsole is listed as potentially being able to work with WP8, but I don't see any references to it in issues here.

Has anyone looked at why mouse clicks don't register in Konsole?

taviso commented 9 months ago

I think the problem is that I've only implemented DEC locator mode - because it was very close to the format (but not quite) that WP8 expects, and XTerm supports it... I don't know what terminal the mouse support was originally designed for, I couldn't find any matching mode anywhere!

This isn't a problem, we just need to translate whatever mode Konsole supports...I'm guessing it's the VT200 locator mode?

I think it should be an easy patch, now that I know there is a Konsole user interested, I should take a look :)

dialognewmedia-mws commented 9 months ago

That would be great, thanks! 

I've not tinkered w/Konsole code since 4.x but it still seems to be doing vt102 based on this. I see no meaningful vt200 references in the master tree. Here's the .h for the vt102 emulation:

https://github.com/KDE/konsole/blob/66aafdc28be471da6aaec5172472efe938966915/src/Vt102Emulation.h

On Tuesday, October 03, 2023 02:33 PM PDT, Tavis Ormandy @.> wrote:     I think the problem is that I've only implemented DEC locator mode - because it was very close to the format (but not quite) to the mode that WP8 expects, and XTerm supports it... I don't know what terminal the mouse support was originally designed for, I couldn't find any matching mode anywhere! This isn't a problem, we just need to translate whatever mode Konsole supports...I'm guessing it's the VT200 locator mode? I think it should be an easy patch, now that I know there is a Konsole user interested, I should take a look :) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/taviso/wpunix/issues/46#issuecomment-1745760156", "url": "https://github.com/taviso/wpunix/issues/46#issuecomment-1745760156", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]***>

 

abstractheron commented 9 months ago

I'll go ahead and add that mouse support seems to not be working in wezterm as well, though I couldn't tell you what wezterm's insides look like