search

tavrez / openssh-sk-winhello

A helper for OpenSSH to interact with FIDO2 and U2F security keys through native Windows Hello API
GNU Lesser General Public License v3.0
184 stars 14 forks source link

Support for platform authenticator (TPM)? #9

Closed zviratko closed 3 years ago

zviratko commented 3 years ago

Hi, I'm working on a PoC with FIDO tokens for SSH keys and I would like to (also) use the built-in Windows Hello FIDO token. However the only option I am given is to insert a security key. Is this a known limitation?

If I had to guess 1) maybe everything needs to be signed correctly to get access to the platform authenticator or 2) might be related to your mention of WebAuthNIsUserVerifyingPlatformAuthenticatorAvailable in ChangeLog or something completely different :-)

Thanks

P.S. are you aware of a way to actually check the attestation data? Looks like OpenSSH does it a bit different from regular WebauthN workflow, in particular there is no clientData in there...

tavrez commented 3 years ago

Hello, OpenSSH only supports ecdsa and ed25519 so I've passed those as the only supported options to Windows Hello. But most of the built-in TPM chips does not support ecdsa and/or ed25519(most of them support RSASSA_PKCS1, which is cose algorithm -257).

are you aware of a way to actually check the attestation data? Looks like OpenSSH does it a bit different from regular WebauthN workflow, in particular there is no clientData in there.

Newer versions of OpenSSH added authenticator data when you save the attestation data, check protocol.u2f for more info about them(check ssh-sk-attest-v01 format)

zviratko commented 3 years ago

Ouch. Would be perfect for OpenSSH to add "rsa-sk" support then. Not sure where to bug them, though.

Yeah, I've seen them add authData, but AFAIK that's not sufficient to verify the attestation. It's true that my starting point was mangling WebauthN tools, but everything I read indicates that clientData is part of the signed data (not necesarilly part of what the authenticator returns, though). It's absolutely possible I am wrong, though, neither me nor my colleagues who tried are fluent in cryptography... :)

tavrez commented 3 years ago

Would be perfect for OpenSSH to add "rsa-sk" support then. Their aim is to support security keys like yubikey, since those keys do not support rsa, they probably won't implement such option.

About clientData, I'm not sure because I did a simple verification for test long time ago, maybe this guide could help.