taw
commented
1 year ago For card choices, usually special versions have special frame effects, so indexer picks the less fancy one, and usually it just works.
I guess for 40K mtgjson might not have the right information yet. I normally don't touch it until a few week after the release, as it takes times.
If indexer doesn't have any criteria to decide which card to choose, I get a warning at build time.
The full list of warnings (not counting GN3; basic lands and some such cards not included in the warnings) before the PR:
40k Forces of the Imperium: Cannot resolve Mind Stone. Candidates are: [40K:244] [40K:244★] [40K:245] [40K:245★]
40k Forces of the Imperium: Cannot resolve Talisman of Dominance. Candidates are: [40K:254] [40K:254★] [40K:255] [40K:255★]
40k Forces of the Imperium: Cannot resolve Arcane Signet. Candidates are: [40K:227] [40K:227★] [40K:228] [40K:228★] [40K:229] [40K:229★]
40k Forces of the Imperium: Cannot resolve Commander's Sphere. Candidates are: [40K:233] [40K:233★] [40K:234] [40K:234★] [40K:235] [40K:235★]
40k Forces of the Imperium: Cannot resolve Command Tower. Candidates are: [40K:270] [40K:270★] [40K:271] [40K:271★] [40K:272] [40K:272★]
40k Forces of the Imperium: Cannot resolve Marneus Calgar. Candidates are: [40K:8] [40K:175]
40k Forces of the Imperium: Cannot resolve Inquisitor Greyfax. Candidates are: [40K:3] [40K:173]
40k Necron Dynasties: Cannot resolve Arcane Signet. Candidates are: [40K:227] [40K:227★] [40K:228] [40K:228★] [40K:229] [40K:229★]
40k Necron Dynasties: Cannot resolve Commander's Sphere. Candidates are: [40K:233] [40K:233★] [40K:234] [40K:234★] [40K:235] [40K:235★]
40k Necron Dynasties: Cannot resolve Mind Stone. Candidates are: [40K:244] [40K:244★] [40K:245] [40K:245★]
40k Necron Dynasties: Cannot resolve Wayfarer's Bauble. Candidates are: [40K:261] [40K:261★] [40K:262] [40K:262★]
40k Necron Dynasties: Cannot resolve Imotekh the Stormlord. Candidates are: [40K:5] [40K:169]
40k Necron Dynasties: Cannot resolve Szarekh, the Silent King. Candidates are: [40K:1] [40K:170]
40k The Ruinous Powers: Cannot resolve Talisman of Dominance. Candidates are: [40K:254] [40K:254★] [40K:255] [40K:255★]
40k The Ruinous Powers: Cannot resolve Commander's Sphere. Candidates are: [40K:233] [40K:233★] [40K:234] [40K:234★] [40K:235] [40K:235★]
40k The Ruinous Powers: Cannot resolve Wayfarer's Bauble. Candidates are: [40K:261] [40K:261★] [40K:262] [40K:262★]
40k The Ruinous Powers: Cannot resolve Command Tower. Candidates are: [40K:270] [40K:270★] [40K:271] [40K:271★] [40K:272] [40K:272★]
40k The Ruinous Powers: Cannot resolve Be'lakor, the Dark Master. Candidates are: [40K:6] [40K:172]
40k The Ruinous Powers: Cannot resolve Abaddon the Despoiler. Candidates are: [40K:2] [40K:171]
40k Tyranid Swarm: Cannot resolve Arcane Signet. Candidates are: [40K:227] [40K:227★] [40K:228] [40K:228★] [40K:229] [40K:229★]
40k Tyranid Swarm: Cannot resolve Command Tower. Candidates are: [40K:270] [40K:270★] [40K:271] [40K:271★] [40K:272] [40K:272★]
40k Tyranid Swarm: Cannot resolve Magus Lucea Kane. Candidates are: [40K:7] [40K:174]
40k Tyranid Swarm: Cannot resolve The Swarmlord. Candidates are: [40K:4] [40K:176]
clb Draconic Dissent: Cannot resolve Firkraag, Cunning Instigator. Candidates are: [CLB:648] [CLB:933]
clb Exit from Exile: Cannot resolve Faldorn, Dread Wolf Herald. Candidates are: [CLB:647] [CLB:932]
clb Mind Flayarrrs: Cannot resolve Captain N'ghathrod. Candidates are: [CLB:646] [CLB:931]
clb Party Time: Cannot resolve Nalia de'Arnise. Candidates are: [CLB:649] [CLB:934]
ncc Bedecked Brokers: Cannot resolve Perrie, the Pulverizer. Candidates are: [NCC:5] [NCC:190]
ncc Cabaretti Cacophony: Cannot resolve Kitt Kanto, Mayhem Diva. Candidates are: [NCC:4] [NCC:189]
ncc Maestros Massacre: Cannot resolve Anhelo, the Painter. Candidates are: [NCC:1] [NCC:186]
ncc Obscura Operation: Cannot resolve Kamiz, Obscura Oculus. Candidates are: [NCC:3] [NCC:188]
ncc Riveteers Rampage: Cannot resolve Henzie "Toolbox" Torre. Candidates are: [NCC:2] [NCC:187]
neo Dimir Control: Cannot resolve Blood on the Snow. Candidates are: [KHM:79] [KHM:348]
neo Mono White Aggro: Cannot resolve Faceless Haven. Candidates are: [KHM:255] [KHM:371]After the PR got merged it's just these:
clb Draconic Dissent: Cannot resolve Firkraag, Cunning Instigator. Candidates are: [CLB:648] [CLB:933]
clb Exit from Exile: Cannot resolve Faldorn, Dread Wolf Herald. Candidates are: [CLB:647] [CLB:932]
clb Mind Flayarrrs: Cannot resolve Captain N'ghathrod. Candidates are: [CLB:646] [CLB:931]
clb Party Time: Cannot resolve Nalia de'Arnise. Candidates are: [CLB:649] [CLB:934]
ncc Bedecked Brokers: Cannot resolve Perrie, the Pulverizer. Candidates are: [NCC:5] [NCC:190]
ncc Cabaretti Cacophony: Cannot resolve Kitt Kanto, Mayhem Diva. Candidates are: [NCC:4] [NCC:189]
ncc Maestros Massacre: Cannot resolve Anhelo, the Painter. Candidates are: [NCC:1] [NCC:186]
ncc Obscura Operation: Cannot resolve Kamiz, Obscura Oculus. Candidates are: [NCC:3] [NCC:188]
ncc Riveteers Rampage: Cannot resolve Henzie "Toolbox" Torre. Candidates are: [NCC:2] [NCC:187]
neo Dimir Control: Cannot resolve Blood on the Snow. Candidates are: [KHM:79] [KHM:348]
neo Mono White Aggro: Cannot resolve Faceless Haven. Candidates are: [KHM:255] [KHM:371]So all 40K issues got fixed by this PR. If you could take a look at these CLB/NCC/NEO issues, that would also be great as well.
Another small know issue is that some of the commander decks have multiple foils per decks, but at release time they didn't tell us which cards are foils other than the main commander, so a few sets will have incomplete [foil] annotations.
Other than that, I think we're good.
davidmartos96
Hello! I was taking a look at the decks and I noticed that, same as #14 , there are a few other cards that change the printing depending on the deck it appears. These are the cards:
Another issue I noticed is the number chosen for the main and alternative commanders. The ones picked are the surge foil versions of the cards, but those only appear in the $100+ Collector's edition of the deck precons. I changed them to the regular foil versions.
I splitted the commits in case it helps reviewing.