search

taw / magic-preconstructed-decks

Magic: the Gathering Preconstructed Decks
7 stars 10 forks source link

Fix Forces of the Imperium (40K) printings and foil printings from CLB and GN3 #17

Closed davidmartos96 closed 1 year ago

davidmartos96 commented 1 year ago

Hello! It looks like the Forces of the Imperium deck is picking 2 regular cards as surge foil. The reason seems to be that the frame effect called "miracle" is missing from the surge foil printing in the Scryfall API, probably due to a bug. That results in the script prioritizing the surge foil one. I hardcoded the collector number so that they are picked regardless of the frame effect is this situation.

Normal printing has frame effects https://api.scryfall.com/cards/f78f5b9a-bd80-41e9-873e-826628dc44a7?format=json&pretty=true

Surge foil printing doesn't have frame effects https://api.scryfall.com/cards/3698b37f-0d86-42ea-9031-8f7e54b5d953?format=json&pretty=true

davidmartos96 commented 1 year ago

I've also included fixes for foil cards in Commander Legends: Battle for Baldurs Gate and Game Night 2022

Each CLB deck contains 2 foil cards, the main and the alternative commanders. tcgplayer The 5 new cards in GN3 are foil as well. tcgplayer

davidmartos96 commented 1 year ago

Each CLB deck also contains an extra foil, having a total of 3 foils. For instance Clan Crafter tcgplayer

Here Card Kingdom shows each deck contains 3 traditional foils Card Kingdom sealed product

taw commented 1 year ago

Thanks.