Closed taw closed 1 year ago
I'm good to do the data entry. There are two options:
Besides SLD do you have any specific products that you're looking for? The only ones I can think of that aren't already included are:
For now I just setup one box
type and uploaded example product.
For SLD at least, I don't think size checking makes any sense.
It's fine to add extra types.
(halfdeck is already a type for UND, so there's already not-really-deck products here)
I might also add some flags for what's a deck and what's not-really-a-deck to types list at some point, but we'll get there when we get there.
Here's where I'm working on this: https://github.com/taw/magic-preconstructed-decks/pull/36
This is just cards sorted by their subset property and attached to different files right now. Still a lot of cleanup work to do to fix bonus cards, missing tokens, double faced cards, etc.
Do we want to add non-SLD box sets?
Do you have an example? I don't know what kind of product you're referencing.
So there's box products that are just the whole set like FTV, SS1 etc., I don't think there's that much value is in, I guess maybe for sake of completeness.
For other products, there's things like:
I don't think any of that is terribly important. We could either add them, or decide that we're done with this issue.
Ah, ok. I can work on adding them slowly but it'll probably be a lower priority thing right now.
We can probably close the issue if you are able to validate that all of those products are showing up in https://mtg.wtf/product. If they're in that list, then I'll eventually get around to adding them to the system.
I thought about Land stations, and I don't know that people care enough about exactly what lands are in the list. If there are any special promo cards that come with it or something I can record those but just the lands aren't really enough to warrant their own deck.
Yeah, all of this looks pretty low priority.
I'm tracking sets & products that are missing homes here: https://github.com/mtgjson/mtgjson/issues/1070
If you find any specific products or sets that are missing things feel free to mention it there.
I currently follow mtgjson by ignoring zero-card sets and assigning their products to best matching set with cards.
Then that same procedure needs to be implemented for the sealed products. I don't know how to make that happen besides putting up and tracking the problems as they arise.
I think we're done here now? Not counting SLD boxes coming out every month?
I'm still working through new products and there are definitely things I haven't uploaded yet. Secret Lairs are still coming out, and I'm still loading the deck builder's toolkits and lots of the promo boxes like the SDCC ones.
I don't really know that leaving this issue open is really doing anything though. The issue is more over at https://github.com/mtgjson/mtg-sealed-content
OK, closing this issue then.
This repo contains decks, but there are other non-randomized boxed products, and there's no reason to not have them as well.
Type would probably be
box
and no distinction between main / side / commander, all cards would be main. Everything else would work the same.Especially interesting would be SLD with so many products.