taw / magic-preconstructed-decks

Magic: the Gathering Preconstructed Decks
6 stars 9 forks source link

"From Cute to Brute" Secret Lair deck #40

Closed davidmartos96 closed 1 year ago

davidmartos96 commented 1 year ago

Hello, here is a work in progress on the From Cute to Brute deck. The Commander and 4 cards are the new Secret Lair printings. I specified the set and number for those. The remaining 95 cards are stamped in the corner with the Planeswalker icon, same as the other Secret Lair deck, "Heads I Win, Tails you Lose" (PHED) https://scryfall.com/sets/phed

Since these printings are not yet available on Scryfall or MTGJSON I used the sld folder, but that should probably be changed once we have a particular set code for the deck, so that the printings resolve correctly.

https://magic.wizards.com/en/news/announcements/commander-returns-to-secret-lair-with-from-cute-to-brute https://secretlair.wizards.com/us/product/819075/secret-lair-commander-deck-from-cute-to-brute https://mtg.fandom.com/wiki/Secret_Lair_Commander_Deck:_From_Cute_to_Brute

axxroytovu commented 1 year ago

@taw this is breaking the search engine because the SLD "set" release date doesn't match up with the deck release date, and cards like Dennick, Pious Apprentice are breaking.

deck_printing_resolver.rb:124:in 'resolve_set': All printings of Dennick, Pious Apprentice from the future

Can we adjust the deck parser to use the recorded deck release date if it exists? Right now it just uses release_date(deck_set_code), so it thinks that the deck was released in 2019 and all printings of the MID/VOW cards are from "future".

taw commented 1 year ago

@axxroytovu Date handling can now deal with this.