taw / magic-preconstructed-decks

Magic: the Gathering Preconstructed Decks
6 stars 9 forks source link

Add some annotations for what kind of "deck" it is #68

Closed taw closed 10 months ago

taw commented 11 months ago

There's a lot of things in this dataset that aren't really precons.

There's a type field, but that's just whatever WotC labelled it as, and they've not been super consistent.

I think two extra fields would help.

Issues where I have an answer (but please comment if you have a different opinion):

Still open issues:

axxroytovu commented 11 months ago

I think we also need format:Shandalar, alchemy, brawl, jumpstart

The WCxx decks are format:null because the cards aren't legal for play.

Maybe instead of "in game deck" you use Arena/MTGO/Shandalar to further differentiate?

taw commented 11 months ago

Weren't WCxx literally from Standard tournaments, except in non-tournament legal printings? I'm not sure if that's format: standard, or format: null.

taw commented 11 months ago

I started adding some categories.

There's some weird small products (are they all box?). I'll also need to check if all intro/theme/mtgo/etc. decks are same format or not.

I don't remember which precons were Standard and which were Casual. IIRC WotC used to release both under fairly generic names.

Do we need another field for platform?

kodawah commented 11 months ago

Weren't WCxx literally from Standard tournaments, except in non-tournament legal printings? I'm not sure if that's format: standard, or format: null.

WCxx was but PTC decks had a variation in which 5 non-standard cards were added -- given the weird state, maybe a spearate category is needed? memorabilia?

what's the usecase for adding a format like "standard" or "brawl" given these are rotational?

taw commented 11 months ago

The precon db is mostly of historical interest, it's not like anyone is going to take a Commander or Modern deck from 5-10 years ago and try to play it in a tournament. Cards could be banned by now, or it would just be unplayable anyway.

My format legality checker can be pointed at any date (except for edge cases like Arena rebalanced cards, pre-1997 Magic, and Penny Dreadful), so might as well use that.

I'll tag "ptc" as casual if it's in no established format.

taw commented 11 months ago

Here's the decks format checker flags, either for not being the format they say, or for being Standard when they're tagged casual:

["uds", "Enchanter - Enhanced Deck", 75, "Enhanced Deck", "guide", "standard", "FAIL"]
* Time Spiral
["uds", "Fiendish Nature - Enhanced Deck", 75, "Enhanced Deck", "guide", "standard", "FAIL"]
* Recurring Nightmare
["m19", "Red-White Deck", 60, "Spellslinger Starter Kit", "deck", "standard", "FAIL"]
* Inspiring Captain
["q07", "Mono White Aggro", 75, "Challenger Deck", "deck", "standard", "FAIL"]
* Faceless Haven
["q08", "Izzet Phoenix", 75, "Pioneer Challenger Deck", "deck", "pioneer", "FAIL"]
* Expressive Iteration
taw commented 11 months ago

OK, this is working well enough that I included it in json exports. We can tweak the edge cases. Please report any issues you have.

taw commented 10 months ago

If nobody has any issues with current implementation, I'm going to close it. Let me know if it's working for you.