taw / magic-preconstructed-decks

Magic: the Gathering Preconstructed Decks
6 stars 9 forks source link

Commander Deck display commanders #78

Closed axxroytovu closed 1 month ago

axxroytovu commented 8 months ago

The thick display commander cards are not represented anywhere and should be included in the sideboard for commander decks.

taw commented 8 months ago

I added extra section "Bonus" to decklists, like here.

Right now it's merged with sideboard by indexer. For now the only difference is that there's no warning printed that number of cards is unexpected. But I'd like to separate it later. In principle tokens etc. could also go there.

I'm not particularly attached to the name "Bonus", but "Additional Contents" is a bit long, and I couldn't come with anything else.

axxroytovu commented 8 months ago

I'm not particularly attached to the name "Bonus", but "Additional Contents" is a bit long, and I couldn't come with anything else.

Maybe "Extra"?

kodawah commented 8 months ago

I like Extra, but maybe we could keep them both?

After all the Bonus category could be for cards that were "unexpected" (like the sld promos) while the Extra section could be used for anything (known) but not useful for the deck, like thick or oversized cards (or tokens)

taw commented 8 months ago

We could make arbitrary number of sections to really annotate "Planar Deck", "Attraction Deck", "Contraption Deck", "Display Commander", "Tokens" etc., but it feels like a bit much for now.

Precons that aren't decks or half-decks probably should just have one main section. (unless we do Tokens at some point)

kodawah commented 8 months ago

tangentially related https://github.com/taw/magic-preconstructed-decks/pull/82

I added the bonus card in the bonus section, I'm still not convinced the thick display cards should be in there too (and rather they should be in sideboard probably)

taw commented 8 months ago

Changed the format again and got rid of "Bonus" name. Example:

<maindeck cards>
...
2 Plains
2 Island
3 Forest

Commander
1 The Fourth Doctor [foil] [WHO:2]
1 Sarah Jane Smith [foil] [WHO:6]

Planar Deck
1 The Pyramid of Mars
1 Caught in a Parallel Universe
1 Gardens of Tranquil Repose
1 Spectrox Mines
1 Coal Hill School
1 UNIT Headquarters
1 The Cheetah Planet
1 Antarctic Research Base
1 The Cave of Skulls
1 TARDIS Bay

Display Commander
1 The Fourth Doctor [foil] [WHO:193]

("Alternative Commander" feels like going too far)

taw commented 8 months ago

I dropped "Additional Commander".

Sections "Planar Deck" and "Display Commander" are now displayed in the UI.

They're still exported as part of the sideboard for compatibility.

taw commented 8 months ago

I created https://github.com/taw/magic-preconstructed-decks/issues/85 for finishing this system.

taw commented 1 month ago

I think this is done. Feel free to reopen if there's anything left to do.