taw / paradox-tools

Utilities for formats found in various Paradox games (Europa Universalis, Crusader Kings etc.)
MIT License
43 stars 8 forks source link

Some of the CK2 analysis tools not working #13

Closed sjp15991 closed 4 years ago

sjp15991 commented 4 years ago

Hey, love these tools, really provide some great and interesting insights, thanks so much for making them and releasing them! Just one quick thing, I ran through nearly all the items in the \analysis_ck2 subfolder. A decent number of them don't work (traits_statistics, vassal_cultures, religions_by_realm and province_development are examples) and seem to think my save file is compressed. But most of the other ones I tried do work and correctly view my save file as uncompressed.

taw commented 4 years ago

Hey. Different scripts have different command line usage (some take just game path, some just save path, some both). Did you check that? If you think you're using it correctly, let me know which ones don't work and upload not working save somewhere.

sjp15991 commented 4 years ago

Ah ok. How do I check that? Is there a guide somewhere within the documents? I spent quite a while looking for it and working out how things work by trial and error. I'm quite new to Ruby so there's a chance I am completely missing something. The readme doesn't include all the analysis scripts or any instructions so I pieced it together from comments here on github. Don't want that to sound like a complaint man, this is great work! Thank you so much for doing it and replying.

taw commented 4 years ago

If you run any script without arguments it should tell you the usage.

I don't think I did a very good job with this, I never remember that myself ;-)

sjp15991 commented 4 years ago

Hey man, I'm not 100% sure what you mean but I think I've done what you suggest. I tested both one that doesnt work for me (province_development) and one that does (province_tech) and the only difference seems to be it is asking for a root as well as a save. How do I find or assign it a root? Please see code below and thank you again for the help!

C:\Users\Shaun>ruby C:\Users\Shaun\Downloads\paradox-tools-master\paradox-tools-master\analysis_ck2\province_development
Usage: C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/analysis_ck2/province_development <save.ck2> <root> [<mod1> <mod2> ... ] # non-compressed save only

C:\Users\Shaun>ruby C:\Users\Shaun\Downloads\paradox-tools-master\paradox-tools-master\analysis_ck2\province_tech
Usage: C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/analysis_ck2/province_tech <save.ck2> # non-compressed save only
taw commented 4 years ago

Where it says it means path to the game. Some analysis tools need game files.

sjp15991 commented 4 years ago

Ah ok! Thank you so much. Sorry again for the stupid questions (but I guess this might be useful for people with similar issues in the future), but do I simply need to put in the path to the selection of files in the Steam Folder or do I need to specify a folder within them (like "history" or "common")? So for example should "E:\Program Files (x86)\Steam\steamapps\common\Crusader Kings II" work as the path there? Sorry I am unable to check it until back at my main computer.

taw commented 4 years ago

Path to the whole game (so E:\Program Files (x86)\Steam\steamapps\common\Crusader Kings II or such). All tools know where to look inside it.

I guess error reporting could be a lot better.

sjp15991 commented 4 years ago

Hmmm I still can't seem to get it to work. As you can see from the two example below I tried it by copying the root and then copying it without spaces in the line but neither worked. It really may be me being stupid though and if so, sorry. Thanks for any help

C:\Users\Shaun>ruby C:\Users\Shaun\Downloads\paradox-tools-master\paradox-tools-master\analysis_ck2\province_development C:\Users\Shaun\Downloads\paradox-tools-master\paradox-tools-master\analysis_ck2\1150.ck2 E:\Program Files (x86)\Steam\steamapps\common\Crusader Kings II Traceback (most recent call last): 6: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/analysis_ck2/province_development:47:in 'main>' 5: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/analysis_ck2/province_development:47:in new' 4: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/ck2/ck2_analyses.rb:282:in 'initialize' 3: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:16:in 'initialize' 2: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:16:in 'each' 1: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:17:in 'block in initialize' C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:91:in 'add_root!': E:\Program doesn't exist (RuntimeError)

C:\Users\Shaun>ruby C:\Users\Shaun\Downloads\paradox-tools-master\paradox-tools-master\analysis_ck2\province_development C:\Users\Shaun\Downloads\paradox-tools-master\paradox-tools-master\analysis_ck2\1150.ck2 E:\ProgramFiles(x86)\Steam\steamapps\common\CrusaderKingsII Traceback (most recent call last): 6: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/analysis_ck2/province_development:47:in '<main>' 5: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/analysis_ck2/province_development:47:in 'new' 4: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/ck2/ck2_analyses.rb:282:in 'initialize' 3: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:16:in 'initialize' 2: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:16:in 'each' 1: from C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:17:in 'block in initialize' C:/Users/Shaun/Downloads/paradox-tools-master/paradox-tools-master/lib/paradox_game.rb:91:in 'add_root!': E:\ProgramFiles(x86)\Steam\steamapps\common\CrusaderKingsII doesn't exist (RuntimeError)

taw commented 4 years ago

You need to put path in double quotes if it contains spaces.

sjp15991 commented 4 years ago

Ah that worked a dream thank you! Just a heads up for you (if you can be bothered to change such a small problem), when doing the province_development process it works but at the top it says Unknown building ca_study Unknown building ca_garden_1

Which implies to me that it didnt include these items in the analysis - potentially new buildings they added to the game since you last updated these. Thanks for all the help!

taw commented 4 years ago

Are you using any mods? These two look like they come from Personal Castle mod.

The scripts don't have anything hardcoded, that's why they ask for path to the game. You can pass paths to mods (but you need to unpack them first), something like:

ruby C:\Users\Shaun\Downloads\paradox-tools-master\paradox-tools-master\analysis_ck2\province_development 1150.ck2 "E:\Program Files (x86)\Steam\steamapps\common\CrusaderKings II" "E:\wherever\Personal Castle"

Pass as many mods as you want as extra arguments.

Most analysis scripts work this way.

sjp15991 commented 4 years ago

Ah of course! Apologies and thank you!