Tray icon on KDE is off

taw00 / element-rpm

Providing the Element messaging desktop client packaged for the Fedora, Red Hat(IBM), and OpenSUSE families of linux desktop operating systems.

Apache License 2.0

100 stars 17 forks source link

Tray icon on KDE is off #16

Closed imaginaryusername closed 5 years ago

imaginaryusername commented 6 years ago

When installing on Fedora KDE/Plasma: Instead of showing the correct "R" icon in tray that responds to with incoming messages, a purple flat icon was shown instead.

Following the instructions at https://github.com/vector-im/riot-web/issues/3133#issuecomment-398227872 seems to fix the issue, but it requires modification at every reinstall/upgrade. Is it possible to workaround at repo by specifying the env?

akontsevich commented 6 years ago

@imaginaryusername Could You clarify please: what need to modify?

imaginaryusername commented 6 years ago

I'm not sure exactly what to modify else I would have made a PR. But since specifying XDG_Current_Desktop as Unity instead of KDE seems to fix the issue, I figured that the information is useful for a workaround.

akontsevich commented 6 years ago

@imaginaryusername seems need to fix riot.desktop file - add this line there. However did not help me for now, probably after restart or whatever. Good to remove this libappindicator3 at all :) But need it for 2 other applications - works fine without it.

taw00 commented 5 years ago

I'm leaving this open, but I am unsure how to address it at this time.

taw00 commented 5 years ago

Folks, if you had this problem, can you tell me the output of (from the commandline) echo $XDG_CURRENT_DESKTOP ? Thanks.

Right now the .desktop file is setting that to Unity before running riot. This is very wrong and has side-effects.

akontsevich commented 5 years ago

KDE for me.

taw00 commented 5 years ago

KDE for me.

So, the result of echo $XDG_CURRENT_DESKTOP for you is KDE? Mind sharing the result of env | grep XDG ?

And you are running Fedora. Right?

I suspect that if you edit /usr/share/applications/riot.desktop and change XDG_CURRENT_DESKTOP=Unity to XDG_CURRENT_DESKTOP=DOESNTMATTER .... that tray icon will remain. But if you change it to KDE it will disappear again, correct?

akontsevich commented 5 years ago

I'm running openSUSE. Correct icon only with XDG_CURRENT_DESKTOP=Unity. Others show purple square.

taw00 commented 5 years ago

Hmm. Mind sharing the result of env | grep XDG from the commandline?

akontsevich commented 5 years ago

> env | grep XDG
XDG_VTNR=7
XDG_SESSION_ID=2
XDG_SESSION_TYPE=x11
XDG_DATA_DIRS=~/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share
XDG_SESSION_DESKTOP=KDE
XDG_SESSION_CLASS=user
XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0
XDG_CURRENT_DESKTOP=KDE
XDG_SEAT=seat0
XDG_RUNTIME_DIR=/run/user/1000
XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session1
XDG_CONFIG_DIRS=/etc/xdg

taw00 commented 5 years ago

Hmm. Did you hardcode anything in your .bashrc to change any of these values?

akontsevich commented 5 years ago

No, what's wrong with values?

taw00 commented 5 years ago

Nothing. Just covering my bases. I am working up a more generic wrapper around riot to mitigate this, but... ugh. Electron team needs to fix their stuff.

Either that or I nuke some of the lower resolution icons, or... Anyway. I am working on something. :)

akontsevich commented 5 years ago

Electron team needs to fix their stuff.

I agree - definitely not Your stuff! :)

Anyway. I am working on something. :)

New riot rpm version for openSUSE?! ;)

taw00 commented 5 years ago

I have been trying to build on 15.0 today. Thus far... FAIL. Something about node_module pathing. Why!?! Clueless at the moment. It's... infuriating. There is too much "magic" in nodejs.

akontsevich commented 5 years ago

For me node.js clear and good enough :) I like it very much! Writing apps with it and npm is much easier comparing with other tools.

Seeder101 commented 5 years ago

this is a major issue across all Distros. and from what I've read it's an electron issue even with Wire electron app as well.

Pointedstick commented 5 years ago

This is working properly for me now in KDE Plasma 5.15 with Riot 1.0.1. Can anyone confirm?

imaginaryusername commented 5 years ago

Cannot confirm - on Fedora 29 with Plasma 5.14, problem persisting even if using riot.wrapper.sh; diagnosed problem though, have to change UNITY to Unity.

taw00 commented 5 years ago

Cannot confirm - on Fedora 29 with Plasma 5.14, problem persisting even if using riot.wrapper.sh; diagnosed problem though, have to change UNITY to Unity.

Seriously? "Unity"? And not "UNITY"?

imaginaryusername commented 5 years ago

Yep, change to "Unity" and it works automagically, despite how dumb it sounds. Would recommend fixing.

taw00 commented 5 years ago

Yep, change to "Unity" and it works automagically, despite how dumb it sounds. Would recommend fixing.

It's in the queue.

taw00 commented 5 years ago

Shipped! Reopen if it continues to be an issue. And oh, by the way... EL7 is buildable again (through some ugly hackery).