search

taweili / ardublock

ArduBlock is a Block Programming Language for Arduino.
GNU General Public License v3.0
413 stars 292 forks source link

It is better to make the object String thet then to apply an equals m… #169

Closed vedes closed 6 years ago

vedes commented 7 years ago

…ethod

The IrGetCode block uses char as the result, but the string validation methods use either char [] or String. This leads to a type mismatch error in the Arduino source code. It is better to replace the return type in IrGetCode with String.

TonyCallear commented 6 years ago

The description asks a question "It is better to replace the return type in IrGetCode with String." and I don't know the answer - so unsure whether to merge or not.

vedes commented 6 years ago

Welcome back TonyCaller! I just tried to use the ir_getcode block and got an error when I compiling. I tried different ways to connect this block, but nothing is worked. The problem is that IrGetCode result is char[] however variables blocks in checks is need the String type. So I had to change the IrGetCode method to make the program work. Do you have a better solution to this problem? If yes, tell me please.

TonyCallear commented 6 years ago

Well, it compiles in Arduino and does not seem to affect anything else - I am not much help after that! Remember - I don't have the hardware or even much idea of what it's trying to do.

I will merge this later today, unless anyone points out a problem.

vedes commented 6 years ago

Thanks TonyCallear!

imspammers commented 6 years ago

hi :) created an account just to help you as your requested in https://github.com/taweili/ardublock/releases/tag/beta-20171028

i hope i can be of help testing your TC version.