Closed eug-L closed 1 week ago
The changes involve modifying the visibility of the getPropertyAndWidget
method in two files: prestashop1.6/tawkto.php
and prestashop1.7/tawkto.php
. The method's access level is changed from public
to public static
, allowing it to be called on the class itself rather than on instances. The internal logic of the method remains unchanged, continuing to retrieve the current widget configuration.
Files | Change Summary |
---|---|
prestashop1.6/tawkto.php, prestashop1.7/tawkto.php | Method visibility changed from public to public static for getPropertyAndWidget . |
sequenceDiagram
participant C as Class TawkTo
participant M as Method getPropertyAndWidget
C->>M: Call getPropertyAndWidget()
M-->>C: Return widget configuration
Objective | Addressed | Explanation |
---|---|---|
Non-static method Tawkto::getPropertyAndWidget() should not be called statically (#30) | ✅ |
In the code where rabbits hop,
Static methods now won't stop.
TawkTo calls with ease and grace,
Widget's charm in every place!
Hooray for changes, swift and bright,
Coding magic, pure delight! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
fixes #30
Summary by CodeRabbit
New Features
getPropertyAndWidget
method can now be called statically on theTawkTo
class in both PrestaShop 1.6 and 1.7, enhancing flexibility in usage.Bug Fixes