Pull Request for trying to read status response - Githubissues

tawn33y / whatsapp-cloud-api

A Node.js library for creating bots and sending/receiving messages using the Whatsapp Cloud API.

https://www.npmjs.com/package/whatsapp-cloud-api

GNU General Public License v3.0

187 stars 51 forks source link

Pull Request for trying to read status response #43

Closed alfonsusac closed 2 months ago

alfonsusac commented 1 year ago

Added 'Status' types increateBot.types.ts according to https://developers.facebook.com/docs/whatsapp/cloud-api/webhooks/components
Changed on callback parameter to also accept Status
Will now publish 'status' and '\<status-type>' to PubSub when receiving only status
Add new tests to also test for the statuses.

In addition, also added the log() function to console.log to a log.txt in root directory for debugging purposes (can be removed)

tawn33y commented 1 year ago

Hi @alfonsusac,

Thanks for this PR. I'm away from my PC and unable to review at the moment. I will review as soon as I can. Apologies for the inconvenience.

Thanks again 😊

alfonsusac commented 1 year ago

Hi @tawn33y , is there any update to when this PR will be reviewed?

tawn33y commented 1 year ago

Hi @alfonsusac, this is really great work! Thanks for your contribution.

I've left some comments. Think of them as suggestions, not really hard-set instructions. Please feel free to discuss any of them 😀

tawn33y commented 1 year ago

I've made a change that ensures that CI tests run on all PRs: https://github.com/tawn33y/whatsapp-cloud-api/pull/51

Please pull & merge latest from main 😀

tawn33y commented 1 year ago

Hi @alfonsusac, light ping on this

tawn33y commented 1 year ago

This will close #40

tawn33y commented 1 year ago

This will close #44

tawn33y commented 2 months ago

Closing - please read more here.