search

taxamo / taxamo-php

Other
10 stars 7 forks source link

Mixed indentation styles #11

Open joolswills opened 9 years ago

joolswills commented 9 years ago

You have mixed indentation styles in the code (tabs vs spaces)

Taxamo.php Taxamo/Swagger.php

Noticed when viewing on my editor which had visible tab/spaces - but noticeable from github source view too.

tlipski commented 9 years ago

Hi,

Thanks for pointing that out, it's definitely something to fix.

Please note that Taxamo.php along with Models/*.php are autogenerated by swagger-codegen (and actually Swagger.php is an almost vanilla version of the code from generator template), so it's not that problematic as it would be with live code. Of course properly formatted code would be much easier to read so it's worth fixing.

joolswills commented 9 years ago

Thanks yeh - it's nothing major, I was just working on debugging some issues with the Clorida_Taxamo Magento extension (which has lots of indentation mixing), and noticed it in the library.