taxidriveer / Examiner

Fan update for WoW Classic
https://www.curseforge.com/wow/addons/examiner
9 stars 9 forks source link

Inspecting shows no items #6

Closed rebz closed 4 years ago

rebz commented 4 years ago

As of today, when I go to inspect someone I will see no items. If I inspect myself it works fine.

Sometimes when I go from inspecting myself to inspecting another it will briefly show their items, then hide said items while showing empty slots, then the slots will disappear.

Inspecting someone else image

Inspecting myself image

taxidriveer commented 4 years ago

Hi Rebz,

For some reason I don't have this problem, could you let me know how many player entry do you have in the cache ? I'm wondering if you can have this behavior if it gets too big...

PS: You can clear the cache by doing a right click on "Cache" ->"Delete All Entries" and make sure to reload the UI.

rebz commented 4 years ago

@taxidriveer - I had 510 cached players. I cleared cache and performed a /reload. However, the issue persists.

image

rebz commented 4 years ago

I relaunched the game and the issue persists.

rebz commented 4 years ago

If I select someone, click More > Configurations and toggle the Smart Tooltip Anchor on/off, it will enable/disable the Stats button. Then I close the inspect window, re-open, and I can view the person's gear. However, if I close and re-open their gear is hidden; rinse and repeat.

rebz commented 4 years ago

I've tried clearing my cache files and re-installing from scratch, still can't get the addon to work properly as it should.

wazerstar commented 4 years ago

@taxidriveer & @rebz

I had the same issue, and I just figured out. Its honorspy addon causing this issue, i deleted over 120 addons to figure out what was causing this issue with examiner not working.

rebz commented 4 years ago

@wazerstar interesting. I will have to try this out later today. Worth noting that I too am using Honorspy.

wazerstar commented 4 years ago

@wazerstar interesting. I will have to try this out later today. Worth noting that I too am using Honorspy.

What can I say, unless another addon + honorspy at the same time triggering examiner not work, could possible be, since i still had some left after checking all those addon, but maybe original poster should check out if honorspy is causing that for him too.

vanillalad commented 4 years ago

can confirm, it is honorspy causing this isssue.

rebz commented 4 years ago

Confirmed, it is Honorspy. Disabled the addon and Examiner worked immediately.

Closing this issue.

taxidriveer commented 4 years ago

Thanks all, after a quick investigation I think this is due to HonorSpy calling "ClearInspectPlayer" and "NotifyInspect" multiple times when you mouseover a player.

In honorspy.lua at line 58 you have the following code

if (name ~= inspectedPlayerName) then -- changed target, clear currently inspected player ClearInspectPlayer(); ... end

at line 79:

-- we gonna inspect new player, clear old one ClearInspectPlayer(); ... NotifyInspect(unitID);

at line 103

ClearInspectPlayer(); NotifyInspect("target"); -- change real target back to player's target, broken by prev NotifyInspect call

"NotifyInspect" will request inventory data from the player, and since we move our mouse a lot this is beeing called multiples times and confuse Examiner. "ClearInspectPlayer" seems to stop the WoW client from gathering inventory data from the unit. Sometimes Examiner won't have the time to cache the items and will display blank items.. (see WoWWiki)

A quick way to make Examiner working with HonorSpy is to:

  1. Target a player
  2. Make sure you are not targeting someone with your cursor for the next 4 seconds (important!)
  3. Inspect the unit with a keybind (You can configure a keybind in the WoW menu -> Key Bindings -> Other)

You will notice that Examiner will be able to show the player items. Unfortunately I'm not sure that I will be able to fix this, I suggest to either use HonorSpy or Examiner.

wazerstar commented 4 years ago

Thanks for providing that info, so nothing we can do for honorspy dev to make another way that works better? Else I will just mark my target hold down mouse2(mouse disapear & wait 4 seconds and press my newly bind hotkey I for inspect :P )

vanillalad commented 4 years ago

Just use Honor Grinding Tracker instead of honorspy, works basically the same but doesn't break when you use it together with Examiner.

wazerstar commented 4 years ago

Just use Honor Grinding Tracker instead of honorspy, works basically the same but doesn't break when you use it together with Examiner.

I Do not like honortracker, and does only track from the session you are in and had enabled the addon. So inspect on I for me while not pointing cursor at any for 4 seconds works fine for me atm.