taxigps / xbmc-addons-chinese

Addon scripts, plugins, and skins for XBMC Media Center. Special for chinese laguage.
GNU General Public License v2.0
3.17k stars 564 forks source link

[service.subtitles.zimuku] 1.1.4 #269

Closed YK-Samgo closed 4 years ago

YK-Samgo commented 4 years ago

Sorry for the inconvenience. Please use this version and release.

YK-Samgo commented 4 years ago

The major change is uncomment line 28 and line 29, so you can do that if you don't want to reset. Other changes include add changelogs and update comment in service.subtitles.zimuku/addon.xml

YK-Samgo commented 4 years ago

@taxigps 不知道什么时候才会回应这个debug,估计又得一礼拜吧。。。忘了把测试的时候注释掉的代码打开就是个坑啊。 跑到这儿来的兄弟们可以先用这个版本https://github.com/YK-Samgo/xbmc-addons-chinese/releases/tag/v1.1.4

taxigps commented 4 years ago

这个插件1.1.4版我已修改测试可用并发布。因此这个pr没必要,而且代码会冲突。

YK-Samgo commented 4 years ago

这个插件1.1.4版我已修改测试可用并发布。因此这个pr没必要,而且代码会冲突。

可能你是没测试到一些特定编码的东西,我这边有几个视频,不打开那两行就会在line 343 getPlayingFile()的时候挂掉。。。python这日了狗的编码问题呀

-->Python callback/script returned the following error<--
- NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
Error Type: <type 'exceptions.UnicodeEncodeError'>
Error Contents: 'ascii' codec can't encode characters in position 42-43: ordinal not in range(128)
Traceback (most recent call last):
    File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/service.subtitles.zimuku/service.py", line 343, in <module>
        item['file_original_path'] = urllib.unquote(xbmc.Player().getPlayingFile().decode('utf-8'))  # Full path of a playing file
    File "/home/jenkins/workspace/Android-ARM-Leia/tools/depends/xbmc-depends/arm-linux-androideabi-21-release/lib/python2.7/encodings/utf_8.py", line 16, in decode
UnicodeEncodeError: 'ascii' codec can't encode characters in position 42-43: ordinal not in range(128)
-->End of Python script error report<--

另外,要加.sup字幕格式的话,还需要加在service.py的259行,可以考虑把这些变量摘出来放到单独的module里,避免hard code。