TheKoola
commented
4 years ago Looks like the for number loop in line 102 loops over just tonumber = phonenumbers.format... grabbing only the end phone number after the last comma. Lines 104 to 132 need to be indented to be included in the loop.
Also, the return True statements need to be removed from within the loop, the if snapshot: should probably have an else: and the return False should probably be removed at the end of the function definition:
for number in self._settings.get(['recipient_number']).split(','):
tonumber = phonenumbers.format_number(phonenumbers.parse(number, 'US'), phonenumbers.PhoneNumberFormat.E164)
tags = {
'filename': filename,
'elapsed_time': elapsed_time,
'printer_name': self._settings.get(["printer_name"])
}
message = self._settings.get(["message_format", "body"]).format(**tags)
client = TwilioRestClient(self._settings.get(['account_sid']), self._settings.get(['auth_token']))
if snapshot:
try:
client.messages.create(to=tonumber, from_=fromnumber, body=message, media_url=snapshot)
except Exception as e:
# report problem sending sms
self._logger.exception("SMS notification error: %s" % (str(e)))
return False
else:
# report notification was sent
self._logger.info("Print notification sent to %s" % (self._settings.get(['recipient_number'])))
else:
try:
client.messages.create(to=tonumber, from_=fromnumber, body=message)
except Exception as e:
# report problem sending sms
self._logger.exception("SMS notification error: %s" % (str(e)))
return False
else:
# report notification was sent
self._logger.info("Print notification sent to %s" % (self._settings.get(['recipient_number'])))
def _process_snapshot(self, snapshot_path, pixfmt="yuv420p"):I fixed it on my installation and it sends separate texts to all the phone numbers now.
taxilian
enderjones
shadycuz
While attempting to send the SMS to multiple phone numbers, it only sends the SMS to the second number after the comma.