Resolved Issue #20 Not sending to Multiple Number

taxilian / OctoPrint-Twilio

Octoprint plugin for print completion notifications using Twilio (for free w/ trial account)

GNU Affero General Public License v3.0

5 stars 9 forks source link

Resolved Issue #20 Not sending to Multiple Number #21

Closed TheKoola closed 3 years ago

TheKoola commented 4 years ago

Changes to _sent_txt function to cull individual "to" phone numbers separated by commas and loop over sending text message to each one.

TheKoola commented 4 years ago

Updated with new commit:

Moved client, tags and messages out of loop so only done once at beginning
Added return True to end of function after loop since all messages have to be sent successfully to get there. Any fail-to-send message will break loop and return False

shadycuz commented 3 years ago

@TheKoola I'm unable to push to your fork =/

shadycuz-> git push --set-upstream koola fix/multiple_numbers 
Total 0 (delta 0), reused 0 (delta 0)
To github.com:TheKoola/OctoPrint-Twilio.git
 ! [remote rejected] fix/multiple_numbers -> fix/multiple_numbers (permission denied)
error: failed to push some refs to 'git@github.com:TheKoola/OctoPrint-Twilio.git'

I wanted to add some minor changes, but its not a big deal. I can pull your changes in after the python3 fix is confirmed. This fix will be the next thing out the door.

shadycuz commented 3 years ago

@TheKoola Closing this for #24 only because I couldn't make some tweaks and bump the version on your branches =/

Don't worry your commits are still in place and you will get credit + that contributors tag 👍

Thanks for fixing the bug and if you could review my PR, its a bit hard to see the diff correctly, might want to just look at the file.