search

taxjar / taxjar-go

Sales Tax API Client for Go
https://developers.taxjar.com/api/reference/?go
MIT License
15 stars 5 forks source link

Change OrderLineItem.ID from json.Number to string #15

Closed ChristerGustavsson closed 2 years ago

ChristerGustavsson commented 2 years ago

According to the documentation line_items[][id] should be a string and "Unique identifier of the given line item."

Forcing it be a numeric string is problematic. For instance, the platform I'm integrating with uses UUIDs for line item ids. For example:

json: invalid number literal, trying to unmarshal "\"7a921b38-e22c-4243-9c23-c60d9abddffa\"" into Number
    occurred
andrewbohm commented 2 years ago

Can this please get merged as soon as possible. This is an issue since ID should be a string.

sethobey commented 2 years ago

Hi @ChristerGustavsson and thank you for your submission!

We observed that our CI pipeline had an issue so I recently merged some updates to our CI configuration.

We would like to accept your PR submission, so If you don't mind, would you kindly rebase this submission on an updated version of master to allow for the updated Travis CI execution?

Thanks again!

sethobey commented 2 years ago

This PR #15 and related Issue #16 are being addressed in PR #18