Encountered error while testing plugin method OrderRepository::afterGetList() in v2.3.7-p2 due to attempted overwrite of existing data array keys.
Description
We can avoid the need to retrieve/set items on collection entirely with for-loop/pass-object-by-reference to instead modify the underlying object.
Performance
N/A
Testing
Error is visible in Bulk Transaction Sync UI
Steps to recreate
Deploy Luma sample data
As admin, navigate to Stores->Configuration->Sales->Tax
Enable transaction sync
Click "Sync Transactions" button in config UI
Init transaction sync over current date range (as sample data created_at dates should match date of sample data deployment)
Without fix, v2.3 will emit error "Item with the same ID already exists "Magento\Sales\Model\Order\Interceptor" from Taxjar\SalesTax\Plugin\Sales\Model\OrderRepository::class.
Context
Encountered error while testing plugin method
OrderRepository::afterGetList()in v2.3.7-p2 due to attempted overwrite of existing data array keys.Description
We can avoid the need to retrieve/set items on collection entirely with for-loop/pass-object-by-reference to instead modify the underlying object.
Performance
N/A
Testing
Error is visible in Bulk Transaction Sync UI
Steps to recreate
Taxjar\SalesTax\Plugin\Sales\Model\OrderRepository::class.Versions