search

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 30 forks source link

chore: PhpCS compatibility #278

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Implement GitHub actions workflow.

Description

Corrects PhpCS errors and ensures that Magento 2 code standards are adhered to so that GH actions stage passes.

Performance

Increase code quality visibility

Testing

Magento 2.4.2

  1. On fresh Magento 2 installation, deploy sample data and checkout PR branch
  2. Run bin/magento setup:upgrade
  3. Run bin/magento setup:di:compile
  4. Navigate to Stores > Configuration > Sales > Tax and connect to TaxJar
  5. Sync Nexus from TaxJar image
  6. Tax calculation - Admin (non-nexus) Screen Shot 2022-03-04 at 5 40 30 PM
  7. Tax calculation - Admin (has nexus) Screen Shot 2022-03-04 at 5 42 56 PM
  8. Order view transaction sync disabled Screen Shot 2022-03-04 at 5 43 07 PM
  9. Non-syncable order view transaction sync enabled Screen Shot 2022-03-04 at 5 43 49 PM
  10. Syncable order view transaction sync enabled Screen Shot 2022-03-04 at 5 44 24 PM
  11. Creditmemo view transaction sync enabled Screen Shot 2022-03-04 at 5 45 16 PM
  12. Address validation admin create order Screen Shot 2022-03-04 at 5 52 12 PM
  13. Address validation checkout Screen Shot 2022-03-04 at 5 54 27 PM
  14. Tax Calculation - Checkout Screen Shot 2022-03-04 at 5 55 52 PMScreen Shot 2022-03-04 at 5 58 10 PMScreen Shot 2022-03-04 at 5 56 47 PM
  15. Backup rates - enable Screen Shot 2022-03-04 at 6 00 05 PMScreen Shot 2022-03-04 at 6 01 13 PM
  16. Backup rates - process bulk action Screen Shot 2022-03-04 at 6 04 32 PMScreen Shot 2022-03-04 at 6 04 01 PM
  17. Debug mode image

Versions