chore: Correct remaining PHPCS sniffs - Githubissues

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar

http://www.taxjar.com/guides/integrations/magento2/

Open Software License 3.0

22 stars 30 forks source link

chore: Correct remaining PHPCS sniffs #279

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Implement GitHub actions workflow.

Description

Escape HTML in .phtml templates
Add/remove new line/whitespace characters where necessary (missed in prev. refactor)
Refactor method Smartcalcs::_getLineItems() for cyclomatic complexity check
Slight refactor of Block/Adminhtml/Backup::class to require less escaped output in .phtml

Performance

N/A

Testing

Observe PhpCS checks pass. (See here)
(Further acceptance testing to be done in feat. branch PR)

Versions

[X] Magento 2.4
[ ] Magento 2.3
[X] Magento Open Source (CE)
[ ] Magento Commerce (EE)
[ ] Magento B2B
[ ] Magento Cloud
[X] PHP 7.x