refactor: Block class Backup excessive coupling - Githubissues

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar

http://www.taxjar.com/guides/integrations/magento2/

Open Software License 3.0

22 stars 30 forks source link

refactor: Block class Backup excessive coupling #280

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Implement GitHub actions workflow.

PHP Mess Detector alerted to excessive coupling in Block/Adminhtml/Backup::class

Description

Removes unused dependencies and local vars in Block/Adminhtml/Backup::class
Removed unnecessary URL escape in backup.phtml
Unit tests public functionalities of Block/Adminhtml/Backup::class

Performance

Less dependencies and no unused dependencies are both preferable for performance and maintainability

Testing

Automated testing

Adds unit test coverage for Block/Adminhtml/Backup::class

Manual testing

Enable Backup rates
Observe create rates bulk operations are queued, "0 of XXXX" rates loaded text shown
Run command bin/magento queue:consumers:start taxjar.backup_rates.create
Observe last synced date updated, rates created successfully
Disable backup rates
Observe delete rates bulk operations are queued
Run command bin/magento queue:consumers:start taxjar.backup_rates.delete
Observe rates deleted successfully

Versions

[X] Magento 2.4
[ ] Magento 2.3
[X] Magento Open Source (CE)
[ ] Magento Commerce (EE)
[ ] Magento B2B
[ ] Magento Cloud
[X] PHP 7.x