taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 30 forks source link

refactor: Block class Backup excessive coupling #280

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Implement GitHub actions workflow.

PHP Mess Detector alerted to excessive coupling in Block/Adminhtml/Backup::class

Description

Performance

Less dependencies and no unused dependencies are both preferable for performance and maintainability

Testing

Automated testing

  1. Adds unit test coverage for Block/Adminhtml/Backup::class

Manual testing

  1. Enable Backup rates
  2. Observe create rates bulk operations are queued, "0 of XXXX" rates loaded text shown
  3. Run command bin/magento queue:consumers:start taxjar.backup_rates.create
  4. Observe last synced date updated, rates created successfully Screen Shot 2022-03-05 at 9 21 53 AM
  5. Disable backup rates
  6. Observe delete rates bulk operations are queued
  7. Run command bin/magento queue:consumers:start taxjar.backup_rates.delete
  8. Observe rates deleted successfully Screen Shot 2022-03-05 at 9 20 59 AM

Versions