fix: Cast values for PHP 8.1 compatibility - Githubissues

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar

http://www.taxjar.com/guides/integrations/magento2/

Open Software License 3.0

22 stars 30 forks source link

fix: Cast values for PHP 8.1 compatibility #282

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Refactor for Magento 2.4.4 compatibility and PHP 8.1 support.

Description

Casts potentially null values to expected type

Performance

N/A

Testing

While testing Magento 2.4.4-beta4, encountered errors in the following instances due to null config values:

bin/magento setup:upgrade
Viewing <BASE_URL>/admin/admin/system_config/edit/section/tax
Viewing Sales Order

Issues have been corrected by casting config values to expected types.

Versions

[X] Magento 2.4
[ ] Magento 2.3
[X] Magento Open Source (CE)
[ ] Magento Commerce (EE)
[ ] Magento B2B
[ ] Magento Cloud
[X] PHP 7.x