taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 30 forks source link

fix: Setup Data patch EAV attribute group names #283

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Refactor for Magento 2.4.4 compatibility and PHP 8.1 support.

Description

Current setup data patches previously passed null group name in EAV attribute setup. Passing a null value to this internal function is no longer supported in PHP 8.1. Default group name General will be used instead.

Performance

N/A

Testing

  1. Create a Magento 2.3 or 2.4 instance
  2. Clone repository in to <magento_root>/app/code/Taxjar/SalesTax/
  3. Run bin/magento module:enable Taxjar_SalesTax --clear-static-content
  4. Run bin/magento setup:upgrade
  5. Observe upgrade command completes successfully, data patches are applied

Versions