fix: PhpMD unused parameters - Githubissues

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar

http://www.taxjar.com/guides/integrations/magento2/

Open Software License 3.0

22 stars 30 forks source link

fix: PhpMD unused parameters #285

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Implement GitHub actions workflow.

PHP Mess Detector alerted to multiple unused parameters and methods.

Description

Removes unnecessary unused parameters
Ignores necessary unused parameters (usages such as plugin methods)
Refactors array callback functions (PhpMD cannot detect array callbacks)

Does not refactor Test/Fixture/ usages... Those should be resolved in a separate PR for all integration test fixtures.

Performance

Improves PhpMD coverage

Testing

Manual tests:

Extension connect to/disconnect from TaxJar
Checkout address validation
Checkout tax calculation
Admin order address validation
Admin order tax calculation
Nexus Sync/Delete
Admin UI transaction backfill

Versions

[X] Magento 2.4
[ ] Magento 2.3
[X] Magento Open Source (CE)
[ ] Magento Commerce (EE)
[ ] Magento B2B
[ ] Magento Cloud
[X] PHP 7.x