taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 30 forks source link

fix: Transaction sync config check in refunds #301

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Customer reported issue that refunds were being unexpectedly imported.

Description

A check was previously added in SyncTransaction::class to validate that our transaction sync feature was enabled for the current order's scope, but the same check was not added to SyncRefund::class. When refunds are updated in Magento, the credit memo updated event will trigger our sync refund observer, which should also check that transaction sync is enabled for the related order scope.

This PR adds the same "feature enabled" check in SyncRefund::class observer.

Performance

Bug fix

Testing

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Versions