taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 30 forks source link

fix: Adds revert method to EAV attribute data patches #317

Closed sethobey closed 2 years ago

sethobey commented 2 years ago

Context

Closes #316

Description

Historically, our extension has never included any means of removing TaxJar-specific data including custom EAV attributes or database tables.

With migration to declarative schema, TaxJar-created DB tables are now automatically dropped upon uninstalling the extension which has the effect of breaking some attribute references after uninstalling.

This PR makes it so that our two setup data patches that are currently responsible for EAV attribute creation will now also revert EAV attribute creation.

Performance

Users will no longer have to manually clean-up after extension uninstallation

Testing

https://user-images.githubusercontent.com/47947793/168668628-7597e87c-21fa-462c-8f5b-8addf77d1415.mov

Versions