fix: Trim smart calcs address postcode - Githubissues

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar

http://www.taxjar.com/guides/integrations/magento2/

Open Software License 3.0

22 stars 30 forks source link

fix: Trim smart calcs address postcode #323

Closed sethobey-stripe closed 2 years ago

sethobey-stripe commented 2 years ago

Context

Closes #322

Description

Trim address postal code values in SmartCalcs::_validatePostcode

Performance

Fixes bug

Testing

Tested Smartcalcs functionality via admin sales order input.

Without trim(), the string "94080" will pass while "94080 " will not.
With trim(), both strings "94080" and "94080 " pass regex validation..

Versions

[X] Magento 2.4
[ ] Magento 2.3
[X] Magento Open Source (CE)
[ ] Magento Commerce (EE)
[ ] Magento B2B
[ ] Magento Cloud
[X] PHP 7.x