taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 29 forks source link

fix: Plugin compatibility with CartManagementInterface #327

Closed drew7721 closed 2 years ago

drew7721 commented 2 years ago

Context

Because some stores might use a custom implementation of the CartManagementInterface. We are one of these stores.

Closes #326

Description

Changes the expected class type in the signature to use the interface. Removes duplicated plugin declaration

Performance

There should not be any impact other that increasing the compatibility of the module with stores that might use a custom implementation of the CartManagementInterface

Testing

  1. Updated Test/Unit/Plugin/Quote/Model/QuoteManagementTest.php subject mock from concrete class \Magento\Quote\Model\QuoteManagement to interface \Magento\Quote\Api\CartManagementInterface.

Versions