Fix postcode validation logic - Githubissues

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar

http://www.taxjar.com/guides/integrations/magento2/

Open Software License 3.0

22 stars 29 forks source link

Fix postcode validation logic #329

Closed arvind-curotec closed 2 years ago

arvind-curotec commented 2 years ago

If a customer enters a postcode in format 12345-6789, postcode validation fails. Need to return as soon as the pattern matches.

Context

Postcode validation fails when user enters postcode in format 12345-6789

Description

Fixes the postcode validation logic.

Performance

N/A

Testing

Add product to cart
In the address select country US
Add postcode in format 12345-6789
There will be no tax calculated as the posycode validation fails

Versions

[x] Magento 2.4
[ ] Magento 2.3
[ ] Magento Open Source (formerly Magento 2 Community Edition)
[x] Adobe Commerce (formerly Magento 2 Enterprise Edition)
[ ] PHP 8.2
[x] PHP 8.1
[x] PHP 7.4
[ ] PHP 7.3