taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 29 forks source link

Fix rendering of JS for syncable but not-yet-synced orders #344

Closed sethobey closed 1 year ago

sethobey commented 1 year ago

Context

Identified bug in phtml logic where a Sales Order that has yet to be synced or fails to sync, but has reached a syncable status will not render the necessary JS to manual sync order to TaxJar

Description

Moves PHP endif before JS script tag open so JS will render whether order has been synced or not.

Performance

Break/fix

Testing

  1. Create sales order with TJ module disabled
  2. Enable TJ module
  3. Navigate to sales order
  4. Click "Sync to TaxJar" button in actions panel, order is synced

Versions