taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 29 forks source link

Fix logging of failure on Customer removal #355

Open sethobey-stripe opened 1 year ago

sethobey-stripe commented 1 year ago

Context

Closes #353

Description

Pre v2, TJ interaction w/ Customer object used Observer classes which extended an abstract class where this logger was originally included. With changes to core code and deprecation of previously observed events, these interactions were migrated to use Plugins instead.

Although the happy-path was not affected by this bug, if TaxJar fails to delete a customer for some reason, the absence of a Logger in the CustomerRepository Plugin would not be able to log the error and would also cause the Magento customer deletion process to fail.

Performance

N/A - bug fix

Testing

Added unit test coverage for changes

Versions

jajajaime commented 11 months ago

Can this get merged?

lfolco commented 6 months ago

Apparently not.