search

taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 29 forks source link

Replace dependency on Zend Client with Laminas Client #360

Closed petemcw closed 1 year ago

petemcw commented 1 year ago

Context

The Zend Framework components are deprecated and should be removed from Magento extensions. The replacement library is the Laminas Framework.

Closes #358

Description

These commits are direct line-for-line replacements of the deprecated Zend Framework components in exchange for their Laminas Framework counterparts. No additional logic or syntax has been altered. The included changes allow the extension to be used on Magento v2.4.6.

Performance

N/A - deprecated code replacement

Testing

N/A - no impact on the test suite

Versions

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

petemcw commented 1 year ago

@knowgod I'll take a closer look later this afternoon. I tried to keep everything as close to a direct replacement as possible since I'm not familiar with any of the TaxJar devs or their preferred style. I do think some of the suggestions like replacing the string literals are a great idea regardless.

smolentzov-stripe commented 1 year ago

Hi @petemcw thank you for this submission! This fix was implemented in https://github.com/taxjar/taxjar-magento2-extension/pull/362 and the changes should now be live.