Closed petemcw closed 1 year ago
@knowgod I'll take a closer look later this afternoon. I tried to keep everything as close to a direct replacement as possible since I'm not familiar with any of the TaxJar devs or their preferred style. I do think some of the suggestions like replacing the string literals are a great idea regardless.
Hi @petemcw thank you for this submission! This fix was implemented in https://github.com/taxjar/taxjar-magento2-extension/pull/362 and the changes should now be live.
Context
The Zend Framework components are deprecated and should be removed from Magento extensions. The replacement library is the Laminas Framework.
Closes #358
Description
These commits are direct line-for-line replacements of the deprecated Zend Framework components in exchange for their Laminas Framework counterparts. No additional logic or syntax has been altered. The included changes allow the extension to be used on Magento v2.4.6.
Performance
N/A - deprecated code replacement
Testing
N/A - no impact on the test suite
Versions
[x] Magento 2.4
[ ] Magento 2.3
[x] Magento Open Source (formerly Magento 2 Community Edition)
[ ] Adobe Commerce (formerly Magento 2 Enterprise Edition)
[ ] PHP 8.2
[x] PHP 8.1
[ ] PHP 7.4
[ ] PHP 7.3