Closed rangerz closed 1 year ago
@smolentzov-stripe This pull request only works for Magento 2.4.6 and above.
You should not directly use it and update the module version to release.
ex: Use Magento 2.4.4 to install taxjar/module-taxjar:2.2.0 will fail to get the error message by bin/magento setup:di:compile
Area configuration aggregation... 5/9 [===============>------------] 55% 1 min 466.0 MiB
In ClassReader.php line 57:
Impossible to process constructor argument Parameter #5 [ <required> Magento\Framework\HTTP\LaminasClientFactory $clien
tFactory ] of Taxjar\SalesTax\Model\Smartcalcs class
In GetParameterClassTrait.php line 34:
Class "Magento\Framework\HTTP\LaminasClientFactory" does not exist
This PR should have caused a major version bump to v3 as well as a modification to the composer.json
. The breaks older installs of v2.4.4.
Context
Because https://github.com/taxjar/taxjar-magento2-extension/issues/358 and https://github.com/taxjar/taxjar-magento2-extension/pull/360 still not update.
Description
Magento\Framework\HTTP\LaminasClient
(Magento 2.4.6 and above) to replaceZend_Http_Client
Laminas\Http\Client\Adapter\Socket
is necessary, and the default adapter isMagento\Framework\HTTP\Adapter\Curl
that is missing pass some header (includeAuthorization
). So I got the 401 for UnauthorizedMagento\Framework\HTTP\ClientInterface
, but it does not providePUT
andDELETE
method interfaces. 🙁Performance
N/A
Testing
N/A
Versions