taxjar / taxjar-magento2-extension

Magento 2 Sales Tax Extension by TaxJar
http://www.taxjar.com/guides/integrations/magento2/
Open Software License 3.0
22 stars 30 forks source link

Deprecated Functionality: Creation of dynamic property Taxjar\SalesTax\Model\Transaction\Order\Interceptor::$apiKey is deprecated #373

Open lagunacellar opened 5 months ago

lagunacellar commented 5 months ago

Prerequisites

Description

The practice of creating a dynamic property ($apiKey) on an Interceptor class (Taxjar\SalesTax\Model\Transaction\Order\Interceptor) has been deprecated as of PHP 7.4.

After upgrading to PHP 8.2 in preparation for Magento 2.4.7, we ran into this deprecation issue on Taxjar in order fulfillment and refund.

Steps to Reproduce

  1. Upgrade PHP to 8.2 in preparation for upgrade to Magento 2.4.7
  2. Use Magento 2.4.6-p5 to process an order fulfillment and refund

Expected Result

Expected no errors in order fulfillment or refund

Actual Result

Deprecated Functionality: Creation of dynamic property Taxjar\SalesTax\Model\Transaction\Order\Interceptor::$apiKey is deprecated in /app/vendor/taxjar/module-taxjar/Model/Transaction/Order.php on line 108

Deprecated Functionality: Creation of dynamic property Taxjar\SalesTax\Model\Transaction\Refund\Interceptor::$apiKey is deprecated in /app/vendor/taxjar/module-taxjar/Model/Transaction/Refund.php on line 145

Versions

saderra commented 4 months ago

Same issue. Is 8.2 compatibility being addressed? Also, "Deprecated Functionality: Creation of dynamic property Taxjar\SalesTax\Model\Transaction\Order::$apiKey is deprecated"

ootri commented 4 months ago

Same issue as #366, for a fix see: https://github.com/taxjar/taxjar-magento2-extension/issues/366#issuecomment-1955532451