search

taxjar / taxjar-node

Sales Tax API Client for Node
https://developers.taxjar.com/api/reference/?javascript
MIT License
54 stars 24 forks source link

Refactor Bluebird promises to native promises; closes #21 #32

Closed ScottRudiger closed 5 years ago

ScottRudiger commented 5 years ago

This change removes Bluebird as a dependency and instead uses native promises. Package size is reduced with no change in functionality, as Promise is available in Node v4 (our minimum supported version). See #21 for more motivation behind this.

Maintainers/contributors, please refresh your node_modules after this is merged:

rm -rf node_modules
npm install
ScottRudiger commented 5 years ago

Clean approach to native promises, I like it 👍Can you choose between dangling commas or no dangling commas for params in taxjar.ts? Once that's done, this PR should be good to go!

That's my muscle memory at work; removed the dangling commas for consistency with the rest of the project. 👍