add php versions to Travis

taxjar / taxjar-php

Sales Tax API Client for PHP 5.5+

https://developers.taxjar.com/api/reference/?php

MIT License

68 stars 24 forks source link

add php versions to Travis #37

Closed cmgmyr closed 4 years ago

cmgmyr commented 4 years ago

I noticed that the two latest versions of PHP weren't included. We'll be using this library and are running 7.4 so I wanted to make sure everything would be working ok.

cmgmyr commented 4 years ago

It looks like the each() function call was removed from phpunit 7.0, but unfortunately, that requires PHP 7.1+ but could be a handful of other related problems with testing in PHP 7.4.

The library code appears to be 7.4 compatible at a quick glance. Are you officially supporting 7.3 and 7.4 at this time?

ScottRudiger commented 4 years ago

Thanks for looking into this @cmgmyr; we'll attempt to test and support all more recent versions.

fastdivision commented 4 years ago

@cmgmyr Updated our Travis config to support 7.3 and 7.4. Specs passing 🎉 Encountered a few issues with our HTTP server mocking library but all good now!

cmgmyr commented 4 years ago

Perfect, thanks so much!!