search

taxjar / taxjar-ruby

Sales Tax API Client for Ruby
https://developers.taxjar.com/api/reference/?ruby
MIT License
54 stars 40 forks source link

Added support for setting a proxy #44

Closed zanker-stripe closed 5 years ago

zanker-stripe commented 5 years ago

Hello! We needed support for sending requests through a proxy, which we can't do as-is, so I added support for it.

WebMock doesn't support asserting that a request was made via a proxy (https://github.com/bblimke/webmock/issues/753), so instead we confirm the request worked normally and then verify the proxy config manually.

fastdivision commented 5 years ago

Hi @zanker-stripe, thank you for contributing! We'll review your PR shortly.

zanker-stripe commented 5 years ago

Thank you! We’ve tested it internally and things work fine.

On Fri, Mar 22, 2019 at 15:53 Jake Johnson notifications@github.com wrote:

Hi @zanker-stripe https://github.com/zanker-stripe, thank you for contributing! We'll review your PR shortly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/taxjar/taxjar-ruby/pull/44#issuecomment-475808098, or mute the thread https://github.com/notifications/unsubscribe-auth/AkwSRl6PH1oEoYHht0b3YApVSOKGX-EBks5vZV7TgaJpZM4cBv7M .