Allow setting up HTTP logger

taxjar / taxjar-ruby

Sales Tax API Client for Ruby

https://developers.taxjar.com/api/reference/?ruby

MIT License

54 stars 40 forks source link

Allow setting up HTTP logger #49

Closed cema-sp closed 4 years ago

cema-sp commented 5 years ago

I believe it could be useful to allow logging all HTTP requests done with the gem.

It would allow customers to have a detailed audit/transactions log. Use cases include

instrumenting the number of API calls
debugging payload data
monitoring API latency

Any thoughts, concerns?

ScottRudiger commented 5 years ago

Do you think it makes sense to add the logging configuration to Taxjar::Client rather than Taxjar::API::Request, similar to how we handle an HTTP proxy?

@prsimp Agreed. 👍

cema-sp commented 4 years ago

Sorry, won't be able to get back to it any time soon.