Reflect a proper error by response code

taxjar / taxjar-ruby

Sales Tax API Client for Ruby

https://developers.taxjar.com/api/reference/?ruby

MIT License

54 stars 40 forks source link

Reflect a proper error by response code #83

Open jalkoby opened 2 years ago

jalkoby commented 2 years ago

In case of 502 response code TaxJar raises base TaxJar::Error rather than TaxJar::Error::ServerError which is more accurate and allows to handle only server side errors

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

jalkoby commented 2 years ago

@CLAassistant the page doesn't work