Move Settings Functionality into Standalone Class

taxjar / taxjar-woocommerce-plugin

WooCommerce Sales Tax Plugin by TaxJar

http://www.taxjar.com/woocommerce-sales-tax-plugin/

GNU General Public License v2.0

30 stars 29 forks source link

Move Settings Functionality into Standalone Class #180

Closed dallendalton closed 3 years ago

dallendalton commented 3 years ago

This PR serves as the first step in cleaning up and modernizing the TaxJar WooCommerce integration. It primarily consists of moving most of the settings functionality into its own class, and untying the connect class from the integration class. Along side these changes, the classes that were worked on have also been changed to comply with our code standards.

Click-Test Versions

[X] Woo 5.1
[X] Woo 4.6

Specs Passing

[X] Woo 5.1
[X] Woo 4.6

fastdivision commented 3 years ago

Reviewed all of the code, looking good so far 👍 Going to review again later before approving.