search

taxjar / taxjar-woocommerce-plugin

WooCommerce Sales Tax Plugin by TaxJar
http://www.taxjar.com/woocommerce-sales-tax-plugin/
GNU General Public License v2.0
30 stars 29 forks source link

INT 1954 Test Suite Fixes, Dependency Updates, Required Versions Updates #195

Closed dallendalton closed 3 years ago

dallendalton commented 3 years ago

This PR address includes multiple fixes and improvements for the plugin. They are:

  1. Update development dependencies.
  2. Fix PHP errors when running test suite with PHP 7.4
  3. Fix flakey spec due to rate change.
  4. Fix risky spec discovered in new PHPUnit version
  5. Fix PHP warning in admin when store address fields are not set
  6. Update WordPress required version, PHP minimum version, WooCommerce minimum version WooCommerce tested up to version.

Steps to Reproduce

The test suite fixes can be tested by running the suite. All tests should pass with no failures, errors, etc.

To test the PHP warning in admin:

  1. Enable WP_Debug
  2. Remove the store address, city and zipcode on the WooCommerce Settings page and save the settings.
  3. Go to the TaxJar settings page, the PHP warnings will be displayed at the top of the page.

Expected Result

After applying the PR, no PHP warning will be displayed in the admin.

Click-Test Versions

Specs Passing