Fix for two HPOS related issues and a small improvement for the readme - Githubissues

taxjar / taxjar-woocommerce-plugin

WooCommerce Sales Tax Plugin by TaxJar

http://www.taxjar.com/woocommerce-sales-tax-plugin/

GNU General Public License v2.0

28 stars 29 forks source link

Fix for two HPOS related issues and a small improvement for the readme #255

Open ahumulescu opened 2 weeks ago

ahumulescu commented 2 weeks ago

This PR:

Fixes a bug where the tax would still be calculated for an exempt customer if the order was created by and admin and HPOS was active
Fixes a secondary bug, where the TaxJar meta boxes would not be displayed in each order's individual page if HPOS was active
Fixes a small inconsistency in the readme.txt file, which was introduced in version 2.1.0. The Changelog section does not have the release version section headers bold since then.

Steps to Reproduce

Go to WordPress admin -> WooCommerce -> Settings -> Advanced -> Features -> enable HPOS
Go to Users -> Select a user -> and set the Exemption Type to 'Government'
Go to Orders -> Add order -> Select the user mentioned above, add an and click 'Recalculate'

Expected Result

The tax not being calculated
The meta box being displayed

After applying the PR, this should happen.

The tax will not be calculated for the exempt customers
The meta box will be displayed in each order's individual page

Click-Test Versions

[ ] Woo 9.0

Specs Passing

[ ] Woo 9.0

CLAassistant commented 2 weeks ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}