taxonomicallyinformedannotation / tima

https://taxonomicallyinformedannotation.github.io/tima
https://taxonomicallyinformedannotation.github.io/tima/
GNU General Public License v3.0
9 stars 4 forks source link

[enhancement] as a user, I want to be able to use tima-r from a simple MGF without pre-computed network #28

Closed Adafede closed 2 years ago

Adafede commented 2 years ago

As requested by @RemyMG, implement the "I have no network" mode and document it.

Adafede commented 2 years ago

For now, the pipeline needs a network.

Adafede commented 2 years ago

Hi @RemyMG,

I just pushed a tentative fix: f9bf4b855a58f0def27b308b5f5d814c42d5ab6d

Could you give it a try and tell me if working as expected?

Adafede commented 2 years ago

6d5b04a218ccf0edd87876896813c110bdd43c22 c9ba9908c0c4b1357d7a7d2930723079ba879de0 4c2d05b29a4925487d0383840a605e6f8ea93d58

replacing the previous fix as it was not clear enough for the user

Adafede commented 2 years ago

Following @RemyMG s suggestion, also adding an example minimal feature table: 08b16722cee08820fbf31f6a7cf9a9dbf282526b

Adafede commented 2 years ago

Opening #30

Adafede commented 2 years ago

@RemyMG I think this is now OK, feel free to open again if needed